]> git.ipfire.org Git - thirdparty/kernel/linux.git/commit
fs/bcachefs: Fix __wait_on_freeing_inode() definition of waitqueue entry
authorIngo Molnar <mingo@kernel.org>
Wed, 9 Oct 2024 08:00:09 +0000 (10:00 +0200)
committerIngo Molnar <mingo@kernel.org>
Wed, 9 Oct 2024 08:00:09 +0000 (10:00 +0200)
commit7266f0a6d3bb73f42ea06656d3cc48c7d0386f71
treed97e95344212bb95c5b5e285dcdf9fc447bc6dac
parent0ac8f14ef22a1592b44dc90272aab35e43b0106a
fs/bcachefs: Fix __wait_on_freeing_inode() definition of waitqueue entry

The following recent commit made DEFINE_WAIT_BIT() type requirements stricter:

  2382d68d7d43 ("sched: change wake_up_bit() and related function to expect unsigned long *")

.. which results in a build failure:

  > fs/bcachefs/fs.c: In function '__wait_on_freeing_inode':
  > fs/bcachefs/fs.c:281:31: error: initialization of 'long unsigned int *' from incompatible pointer type 'u32 *' {aka 'unsigned int *'} [-Wincompatible-pointer-types]
  >   281 |         DEFINE_WAIT_BIT(wait, &inode->v.i_state, __I_NEW);

Since this code relies on the waitqueue initialization within
inode_bit_waitqueue() anyway, the DEFINE_WAIT_BIT() initialization
is unnecessary - we can just declare a waitqueue entry.

Reported-by: Stephen Rothwell <sfr@canb.auug.org.au>
Suggested-by: NeilBrown <neilb@suse.de>
Signed-off-by: Ingo Molnar <mingo@kernel.org>
fs/bcachefs/fs.c