]> git.ipfire.org Git - thirdparty/kernel/linux.git/commit
vfio/fsl-mc: Block calling interrupt handler without trigger
authorAlex Williamson <alex.williamson@redhat.com>
Fri, 8 Mar 2024 23:05:28 +0000 (16:05 -0700)
committerAlex Williamson <alex.williamson@redhat.com>
Mon, 11 Mar 2024 19:08:52 +0000 (13:08 -0600)
commit7447d911af699a15f8d050dfcb7c680a86f87012
tree1c3316e6a276bb0155727fdc0f2763bbf18536e2
parent675daf435e9f8e5a5eab140a9864dfad6668b375
vfio/fsl-mc: Block calling interrupt handler without trigger

The eventfd_ctx trigger pointer of the vfio_fsl_mc_irq object is
initially NULL and may become NULL if the user sets the trigger
eventfd to -1.  The interrupt handler itself is guaranteed that
trigger is always valid between request_irq() and free_irq(), but
the loopback testing mechanisms to invoke the handler function
need to test the trigger.  The triggering and setting ioctl paths
both make use of igate and are therefore mutually exclusive.

The vfio-fsl-mc driver does not make use of irqfds, nor does it
support any sort of masking operations, therefore unlike vfio-pci
and vfio-platform, the flow can remain essentially unchanged.

Cc: Diana Craciun <diana.craciun@oss.nxp.com>
Cc: <stable@vger.kernel.org>
Fixes: cc0ee20bd969 ("vfio/fsl-mc: trigger an interrupt via eventfd")
Reviewed-by: Kevin Tian <kevin.tian@intel.com>
Reviewed-by: Eric Auger <eric.auger@redhat.com>
Link: https://lore.kernel.org/r/20240308230557.805580-8-alex.williamson@redhat.com
Signed-off-by: Alex Williamson <alex.williamson@redhat.com>
drivers/vfio/fsl-mc/vfio_fsl_mc_intr.c