]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
drm/amd/display: Write to correct dirty_rect
authorBenjamin Cheng <ben@bcheng.me>
Mon, 13 Mar 2023 00:47:39 +0000 (20:47 -0400)
committerAlex Deucher <alexander.deucher@amd.com>
Tue, 14 Mar 2023 14:40:02 +0000 (10:40 -0400)
commit751281c55579f0cb0e56c9797d4663f689909681
treec5b9692058c95e3254058cb35c3952367547d6da
parent3fadda5de8073e2cb65744803a6941736411d55b
drm/amd/display: Write to correct dirty_rect

When FB_DAMAGE_CLIPS are provided in a non-MPO scenario, the loop does
not use the counter i. This causes the fill_dc_dity_rect() to always
fill dirty_rects[0], causing graphical artifacts when a damage clip
aware DRM client sends more than 1 damage clip.

Instead, use the flip_addrs->dirty_rect_count which is incremented by
fill_dc_dirty_rect() on a successful fill.

Fixes: 30ebe41582d1 ("drm/amd/display: add FB_DAMAGE_CLIPS support")
Bug: https://gitlab.freedesktop.org/drm/amd/-/issues/2453
Signed-off-by: Benjamin Cheng <ben@bcheng.me>
Signed-off-by: Hamza Mahfooz <hamza.mahfooz@amd.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
Cc: stable@vger.kernel.org # 6.1.x
drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c