]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
ASoC: topology: Check return value for snd_soc_add_dai_link()
authorDragos Tarcatu <dragos_tarcatu@mentor.com>
Tue, 10 Dec 2019 00:39:38 +0000 (18:39 -0600)
committerMark Brown <broonie@kernel.org>
Tue, 10 Dec 2019 13:10:00 +0000 (13:10 +0000)
commit76d2703649321c296df7ec0dafd50add96215de4
tree17fa960cdc6ec052415c9cb0ce0efe333ae20ee7
parent9c9b65203492927cc4ae419e9601e837ecbd889e
ASoC: topology: Check return value for snd_soc_add_dai_link()

snd_soc_add_dai_link() might fail. This situation occurs for
instance in a very specific use case where a PCM device and a
Back End DAI link are given identical names in the topology.
When this happens, soc_new_pcm_runtime() fails and then
snd_soc_add_dai_link() returns -ENOMEM when called from
soc_tplg_fe_link_create(). Because of that, the link will not
get added into the card list, so any attempt to remove it later
ends up in a panic.

Fix that by checking the return status and free the memory in case
of an error.

Reviewed-by: Ranjani Sridharan <ranjani.sridharan@linux.intel.com>
Signed-off-by: Dragos Tarcatu <dragos_tarcatu@mentor.com>
Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Link: https://lore.kernel.org/r/20191210003939.15752-2-pierre-louis.bossart@linux.intel.com
Signed-off-by: Mark Brown <broonie@kernel.org>
sound/soc/soc-topology.c