]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
powerpc/powernv: add missing of_node_put
authorJulia Lawall <Julia.Lawall@lip6.fr>
Fri, 20 Nov 2015 20:33:21 +0000 (20:33 +0000)
committerMichael Ellerman <mpe@ellerman.id.au>
Thu, 25 Nov 2021 00:25:29 +0000 (11:25 +1100)
commit7d405a939ca960162eb30c1475759cb2fdf38f8c
tree3ffd89abb8c38f172a6a4ed9b22e84e7fb10c514
parentf6e82647ff71d427d4148964b71f239fba9d7937
powerpc/powernv: add missing of_node_put

for_each_compatible_node performs an of_node_get on each iteration, so
a break out of the loop requires an of_node_put.

A simplified version of the semantic patch that fixes this problem is as
follows (http://coccinelle.lip6.fr):

// <smpl>
@@
local idexpression n;
expression e;
@@

 for_each_compatible_node(n,...) {
   ...
(
   of_node_put(n);
|
   e = n
|
+  of_node_put(n);
?  break;
)
   ...
 }
... when != n
// </smpl>

Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>
Link: https://lore.kernel.org/r/1448051604-25256-4-git-send-email-Julia.Lawall@lip6.fr
arch/powerpc/platforms/powernv/opal-lpc.c