]> git.ipfire.org Git - people/arne_f/kernel.git/commit
platform/x86: mlx-platform: Properly use mlxplat_mlxcpld_msn201x_items
authorNathan Chancellor <natechancellor@gmail.com>
Wed, 26 Sep 2018 05:21:15 +0000 (22:21 -0700)
committerAndy Shevchenko <andriy.shevchenko@linux.intel.com>
Mon, 8 Oct 2018 14:47:43 +0000 (17:47 +0300)
commit8289c4b6f2e53750de78bd38cecb6bce4d7a988c
treed32befd3aece381e471e915cea4267e47536a2ac
parent5aa389aa29ce0fcdd39fa88245bcad6cea6af57c
platform/x86: mlx-platform: Properly use mlxplat_mlxcpld_msn201x_items

Clang warns that mlxplat_mlxcpld_msn201x_items is not going to be
emitted in the final assembly because it's only used in ARRAY_SIZE right
now, which is a compile time evaluation since the array's size is known.

drivers/platform/x86/mlx-platform.c:555:32: warning: variable
'mlxplat_mlxcpld_msn201x_items' is not needed and will not be emitted
[-Wunneeded-internal-declaration]
static struct mlxreg_core_item mlxplat_mlxcpld_msn201x_items[] = {
                               ^
1 warning generated.

It appears this was a copy and paste mistake from when this item was
first added. Use the definition in mlxplat_mlxcpld_msn201x_data so that
Clang no longer warns.

Link: https://github.com/ClangBuiltLinux/linux/issues/141
Fixes: a49a41482f61 ("platform/x86: mlx-platform: Add support for new msn201x system type")
Signed-off-by: Nathan Chancellor <natechancellor@gmail.com>
Acked-by: Vadim Pasternak <vadimp@mellanox.com>
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
drivers/platform/x86/mlx-platform.c