]> git.ipfire.org Git - thirdparty/git.git/commit
test-lib: GIT_TEST_SANITIZE_LEAK_LOG enabled by default
authorRubén Justo <rjusto@gmail.com>
Thu, 11 Jul 2024 14:10:51 +0000 (23:10 +0900)
committerJunio C Hamano <gitster@pobox.com>
Thu, 11 Jul 2024 15:37:44 +0000 (08:37 -0700)
commit8c1d6691bc514e2c1c01a807e872b5dddcb2485b
treedf7132bbc2c5334255dc54ae82bafc51676ba229
parent47c6d4dad22a751068a4975f1c4177cc6c0c41d2
test-lib: GIT_TEST_SANITIZE_LEAK_LOG enabled by default

As we currently describe in t/README, it can happen that:

    Some tests run "git" (or "test-tool" etc.) without properly checking
    the exit code, or git will invoke itself and fail to ferry the
    abort() exit code to the original caller.

Therefore, GIT_TEST_SANITIZE_LEAK_LOG=true is needed to be set to
capture all memory leaks triggered by our tests.

It seems unnecessary to force users to remember this option, as
forgetting it could lead to missed memory leaks.

We could solve the problem by making it "true" by default, but that
might suggest we think "false" makes sense, which isn't the case.

Therefore, the best approach is to remove the option entirely while
maintaining the capability to detect memory leaks in blind spots of our
tests.

Signed-off-by: Rubén Justo <rjusto@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
ci/lib.sh
t/README
t/test-lib.sh