]> git.ipfire.org Git - people/arne_f/kernel.git/commit
HID: alps: Fix an error handling path in 'alps_input_configured()'
authorChristophe JAILLET <christophe.jaillet@wanadoo.fr>
Wed, 4 Dec 2019 03:35:25 +0000 (04:35 +0100)
committerJiri Kosina <jkosina@suse.cz>
Wed, 12 Feb 2020 14:06:19 +0000 (15:06 +0100)
commit8d2e77b39b8fecb794e19cd006a12f90b14dd077
treef54896fdf32f1cfd1d48711f02e134f30df8f848
parent5c02c447eaeda29d3da121a2e17b97ccaf579b51
HID: alps: Fix an error handling path in 'alps_input_configured()'

They are issues:
   - if 'input_allocate_device()' fails and return NULL, there is no need
     to free anything and 'input_free_device()' call is a no-op. It can
     be axed.
   - 'ret' is known to be 0 at this point, so we must set it to a
     meaningful value before returning

Fixes: 2562756dde55 ("HID: add Alps I2C HID Touchpad-Stick support")
Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Signed-off-by: Jiri Kosina <jkosina@suse.cz>
drivers/hid/hid-alps.c