]>
git.ipfire.org Git - thirdparty/Python/cpython.git/commit
gh-120155: Fix copy/paste error in HAVE_SUBOFFSETS_IN_LAST_DIM() (#120228)
Don't hardcode 'dest' in HAVE_SUBOFFSETS_IN_LAST_DIM() macro of
memoryobject.c, but use its 'view' parameter instead.
Fix the Coverity issue:
Error: COPY_PASTE_ERROR (CWE-398):
Python-3.12.2/Objects/memoryobject.c:273:14: original: ""dest->suboffsets + (dest->ndim - 1)"" looks like the original copy.
Python-3.12.2/Objects/memoryobject.c:274:14: copy_paste_error: ""dest"" in ""src->suboffsets + (dest->ndim - 1)"" looks like a copy-paste error.
Python-3.12.2/Objects/memoryobject.c:274:14: remediation: Should it say ""src"" instead?
# 272| assert(dest->ndim > 0 && src->ndim > 0);
# 273| return (!HAVE_SUBOFFSETS_IN_LAST_DIM(dest) &&
# 274|-> !HAVE_SUBOFFSETS_IN_LAST_DIM(src) &&
# 275| dest->strides[dest->ndim-1] == dest->itemsize &&
# 276| src->strides[src->ndim-1] == src->itemsize);