]> git.ipfire.org Git - thirdparty/qemu.git/commit
hw/virtio/vhost-user: avoid using unitialized errp
authorAlbert Esteve <aesteve@redhat.com>
Thu, 2 Mar 2023 12:17:19 +0000 (13:17 +0100)
committerMichael S. Tsirkin <mst@redhat.com>
Wed, 8 Mar 2023 00:51:07 +0000 (19:51 -0500)
commit90e31232cf8fa7f257263dd431ea954a1ae54bff
tree5d605c5056a67948c67c86f6490a0957dbfbc8de
parent154070eaf6597c47f64c3ea917bcba62427ae61f
hw/virtio/vhost-user: avoid using unitialized errp

During protocol negotiation, when we the QEMU
stub does not support a backend with F_CONFIG,
it throws a warning and supresses the
VHOST_USER_PROTOCOL_F_CONFIG bit.

However, the warning uses warn_reportf_err macro
and passes an unitialized errp pointer. However,
the macro tries to edit the 'msg' member of the
unitialized Error and segfaults.

Instead, just use warn_report, which prints a
warning message directly to the output.

Fixes: 5653493 ("hw/virtio/vhost-user: don't suppress F_CONFIG when supported")
Signed-off-by: Albert Esteve <aesteve@redhat.com>
Message-Id: <20230302121719.9390-1-aesteve@redhat.com>
Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
Reviewed-by: Michael S. Tsirkin <mst@redhat.com>
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
hw/virtio/vhost-user.c