]> git.ipfire.org Git - thirdparty/xfsprogs-dev.git/commit
xfs_repair: fix array overrun in do_inode_prefetch
authorEric Sandeen <sandeen@redhat.com>
Thu, 6 Mar 2014 23:33:04 +0000 (10:33 +1100)
committerDave Chinner <david@fromorbit.com>
Thu, 6 Mar 2014 23:33:04 +0000 (10:33 +1100)
commit97b1fcfd16157e2b8dba59f5f90f4aaa9704044b
tree20f9dfc059e7ee61000e35d76839dc89af558ede
parent88f364a9632c6ffc329c098c11807ba2753ab2b6
xfs_repair: fix array overrun in do_inode_prefetch

Coverity spotted this:

do_inode_prefetch() does a while loop, creating queues:

        for (i = 0; i < thread_count; i++) {
...
create_work_queue(&queues[i], mp, 1);
...
}

and then does this to wait for them all to complete:

for (; i >= 0; i--)
destroy_work_queue(&queues[i]);

But we leave the first for loop with (i == thread_coun)t, and
the second one will try to index queues[] one past the end.

Signed-off-by: Eric Sandeen <sandeen@redhat.com>
Reviewed-by: Dave Chinner <dchinner@redhat.com>
Signed-off-by: Dave Chinner <david@fromorbit.com>
repair/prefetch.c