]> git.ipfire.org Git - thirdparty/Python/cpython.git/commit
gh-91447: Fix findtext to only give an empty string on None (GH-91486)
authorEugene Triguba <eugenetriguba@gmail.com>
Mon, 1 Aug 2022 16:52:39 +0000 (11:52 -0500)
committerGitHub <noreply@github.com>
Mon, 1 Aug 2022 16:52:39 +0000 (09:52 -0700)
commita95e60db748ec6f2c19b5710c11f62e1e4d669f4
treef8604f233cab3f2839bf53c59c086841580e211d
parent858c9a58bf56cefc792bf0eb1ba22984b7b2d150
gh-91447: Fix findtext to only give an empty string on None (GH-91486)

The API documentation for [findtext](https://docs.python.org/3/library/xml.etree.elementtree.html#xml.etree.ElementTree.Element.findtext) states that this function gives back an empty string on "no text content." With the previous implementation, this would give back a empty string even on text content values such as 0 or False. This patch attempts to resolve that by only giving back an empty string if the text attribute is set to `None`. Resolves #91447.

Automerge-Triggered-By: GH:gvanrossum
Lib/test/test_xml_etree.py
Lib/xml/etree/ElementPath.py
Misc/NEWS.d/next/Library/2022-04-12-18-05-40.gh-issue-91447.N_Fs4H.rst [new file with mode: 0644]