]> git.ipfire.org Git - thirdparty/linux.git/commit
vdso: Address variable shadowing in macros
authorPeng Jiang <jiang.peng9@zte.com.cn>
Mon, 24 Mar 2025 11:12:30 +0000 (19:12 +0800)
committerThomas Gleixner <tglx@linutronix.de>
Thu, 10 Apr 2025 09:07:10 +0000 (11:07 +0200)
commitacea9943271b62905033f2f8ca571cdd52d6ea7b
treeda0ee158354bdf495f9e6b35f9c5b13d86b63cab
parent92e250c624ea37fde64bfd624fd2556f0d846f18
vdso: Address variable shadowing in macros

Compiling the kernel with gcc12.3 W=2 results in shadowing warnings:

warning: declaration of '__pptr' shadows a previous local [-Wshadow]
  const struct { type x; } __packed *__pptr = (typeof(__pptr))(ptr);

note: in definition of macro '__put_unaligned_t'
  __pptr->x = (val);

note: in expansion of macro '__get_unaligned_t'
  __put_unaligned_t(type, __get_unaligned_t(type, src), dst);

__get_unaligned_t() and __put_unaligned_t() use a local variable named
'__pptr', which can lead to variable shadowing when these macros are used in
the same scope. This results in a -Wshadow warning during compilation.

To address this issue, rename the local variables within the macros to
ensure uniqueness.

Signed-off-by: Peng Jiang <jiang.peng9@zte.com.cn>
Signed-off-by: Shao Mingyin <shao.mingyin@zte.com.cn>
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Link: https://lore.kernel.org/all/20250324191230477zpGtgIRSH4mEHdtxGtgx9@zte.com.cn
include/vdso/unaligned.h