]> git.ipfire.org Git - thirdparty/kernel/linux.git/commit
net: reduce RTNL hold duration in unregister_netdevice_many_notify() (part 1)
authorEric Dumazet <edumazet@google.com>
Tue, 14 Jan 2025 20:55:30 +0000 (20:55 +0000)
committerJakub Kicinski <kuba@kernel.org>
Thu, 16 Jan 2025 03:17:04 +0000 (19:17 -0800)
commitae646f1a0bb97401bac0044bbe2a179a1e38b408
tree241188fb949f54a1ab0cc9c931f284229c31bf70
parentcfa579f6665635b72d4a075fc91eb144c2b0f74e
net: reduce RTNL hold duration in unregister_netdevice_many_notify() (part 1)

Two synchronize_net() calls are currently done while holding RTNL.

This is source of RTNL contention in workloads adding and deleting
many network namespaces per second, because synchronize_rcu()
and synchronize_rcu_expedited() can use 60+ ms in some cases.

For cleanup_net() use, temporarily release RTNL
while calling the last synchronize_net().

This should be safe, because devices are no longer visible
to other threads at this point.

In any case, the new netdev_lock() / netdev_unlock()
infrastructure that we are adding should allow
to fix potential issues, with a combination
of a per-device mutex and dev->reg_state awareness.

Signed-off-by: Eric Dumazet <edumazet@google.com>
Reviewed-by: Jesse Brandeburg <jbrandeburg@cloudflare.com>
Link: https://patch.msgid.link/20250114205531.967841-5-edumazet@google.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
net/core/dev.c