]> git.ipfire.org Git - thirdparty/Python/cpython.git/commit
bpo-42644: Validate values in logging.disable() (#23786)
authorMatthias Bussonnier <bussonniermatthias@gmail.com>
Wed, 16 Dec 2020 09:43:39 +0000 (01:43 -0800)
committerGitHub <noreply@github.com>
Wed, 16 Dec 2020 09:43:39 +0000 (11:43 +0200)
commitb32d8b4f9bcd2e7d11240b6b9de0262cf8f5e09d
tree93929faaa993c0a8de14e46bf1991b1e7805c49a
parent3f9fe23c05280dc5736c07bb0e968cdaf8c503d0
bpo-42644: Validate values in logging.disable() (#23786)

* bpo-42644: Validate values in logging.disable()

Technically make the value of manager a property that checks and convert
values assigned to it properly. This has the side effect of making
`logging.disable` also accept strings representing the various level of
warnings.

We want to validate the type of the disable attribute at assignment
time, as it is later compared to other levels when emitting warnings and
would generate a `TypeError: '>=' not supported between ....` in a
different part of the code base, which can make it difficult to track
down.

When assigned an incorrect value; it will raise a TypeError when the
wrong type, or ValueError if an invalid str.

Co-authored-by: Andrew Svetlov <andrew.svetlov@gmail.com>
Lib/logging/__init__.py
Lib/test/test_logging.py
Misc/NEWS.d/next/Library/2020-12-15-10-00-04.bpo-42644.XgLCNx.rst [new file with mode: 0644]