]> git.ipfire.org Git - thirdparty/Python/cpython.git/commit
gh-100795: Don't call freeaddrinfo on failure. (#101252)
authorGregory P. Smith <greg@krypto.org>
Mon, 23 Jan 2023 23:03:26 +0000 (15:03 -0800)
committerGitHub <noreply@github.com>
Mon, 23 Jan 2023 23:03:26 +0000 (15:03 -0800)
commitb724ac2fe7fbb5a7a33d639cad8e748f17b325e0
treef17a8c5dcf6f6a5bc7f20e05f964d6f3208ffb58
parentbd7903967cd2a19ebc842dd1cce75f60a18aef02
gh-100795: Don't call freeaddrinfo on failure. (#101252)

When getaddrinfo returns an error, the output pointer is in an unknown state
Don't call freeaddrinfo on it.  See the issue for discussion and details with
links to reasoning.  _Most_ libc getaddrinfo implementations never modify the
output pointer unless they are returning success.

Co-authored-by: Sergey G. Brester <github@sebres.de>
Co-authored-by: Oleg Iarygin <dralife@yandex.ru>
Misc/NEWS.d/next/Library/2023-01-21-16-50-22.gh-issue-100795.NPMZf7.rst [new file with mode: 0644]
Modules/socketmodule.c