]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
leds: rgb: leds-qcom-lpg: Fix pwm resolution max for Hi-Res PWMs
authorAbel Vesa <abel.vesa@linaro.org>
Wed, 5 Mar 2025 13:09:05 +0000 (15:09 +0200)
committerLee Jones <lee@kernel.org>
Fri, 21 Mar 2025 09:21:59 +0000 (09:21 +0000)
commitb7881eacc07fdf50be3f33c662997541bb59366d
tree414a0c3e7b3fc2f753b58ea7348b39ba5e3c2453
parent2fc21e4d6fb13145db665e5edaf4129066cc86b5
leds: rgb: leds-qcom-lpg: Fix pwm resolution max for Hi-Res PWMs

Ideally, the requested duty cycle should never translate to a PWM
value higher than the selected resolution (PWM size), but currently the
best matched period is never reported back to the PWM consumer, so the
consumer will still be using the requested period which is higher than
the best matched one. This will result in PWM consumer requesting
duty cycle values higher than the allowed PWM value.

For example, a consumer might request a period of 5ms while the best
(closest) period the PWM hardware will do is 4.26ms. For this best
matched resolution, if the selected resolution is 8-bit wide, when
the consumer asks for a duty cycle of 5ms, the PWM value will be 300,
which is outside of what the resolution allows. This will happen with
all possible resolutions when selected.

Since for these Hi-Res PWMs, the current implementation is capping the PWM
value at a 15-bit resolution, even when lower resolutions are selected,
the value will be wrapped around by the HW internal logic to the selected
resolution.

Fix the issue by capping the PWM value to the maximum value allowed by
the selected resolution.

Cc: stable@vger.kernel.org # 6.4
Fixes: b00d2ed37617 ("leds: rgb: leds-qcom-lpg: Add support for high resolution PWM")
Signed-off-by: Abel Vesa <abel.vesa@linaro.org>
Reviewed-by: Bjorn Andersson <andersson@kernel.org>
Reviewed-by: Sebastian Reichel <sre@kernel.org>
Link: https://lore.kernel.org/r/20250305-leds-qcom-lpg-fix-max-pwm-on-hi-res-v4-2-bfe124a53a9f@linaro.org
Signed-off-by: Lee Jones <lee@kernel.org>
drivers/leds/rgb/leds-qcom-lpg.c