]> git.ipfire.org Git - thirdparty/dovecot/core.git/commit
imap: Removed special EXPUNGE callback for an Outlook workaround.
authorTimo Sirainen <timo.sirainen@dovecot.fi>
Mon, 1 Feb 2016 18:26:19 +0000 (20:26 +0200)
committerTimo Sirainen <timo.sirainen@dovecot.fi>
Mon, 1 Feb 2016 18:26:19 +0000 (20:26 +0200)
commitb7b25e0ae0277930b8197e5fa04dd567ce243ca4
tree17393b1b1c48a6b55f57fbc57f6badedfc44044a
parenta58963a8bdac0438a31abc03711e8870b4dfa4f4
imap: Removed special EXPUNGE callback for an Outlook workaround.

As the comment mentions, this workaround isn't needed if index files are
used.  Hopefully also the Outlook bug itself is gone nowadays.. In any case
the current callback code didn't work, because it was returning FALSE and
causing an assert in a pipelined EXPUNGE+APPEND combination after 6e9454f:

Panic: file imap-client.c: line 862 (client_check_command_hangs): assertion
failed: (!have_wait_unfinished || unfinished_count > 0)

It would probably be possible to fix this, but it would complicate the code
even further, so it's easier just to get rid of this feature. It was easily
triggered by running imaptest stress testing.
src/imap/cmd-expunge.c