]> git.ipfire.org Git - thirdparty/qemu.git/commit
qapi/block-core: deprecate some block-job- APIs
authorVladimir Sementsov-Ogievskiy <vsementsov@yandex-team.ru>
Wed, 9 Apr 2025 08:42:31 +0000 (11:42 +0300)
committerVladimir Sementsov-Ogievskiy <vsementsov@yandex-team.ru>
Thu, 1 May 2025 09:12:19 +0000 (12:12 +0300)
commitb836bf2ab68fbc1e253c10bee95fa36399762967
tree031aadc2e180db69f94801dcea627abf1feeef78
parentda17dd5c5ee8e33124da0bf91aed11491d0c04de
qapi/block-core: deprecate some block-job- APIs

For change, pause, resume, complete, dismiss and finalize actions
corresponding job- and block-job commands are almost equal. The
difference is in find_block_job_locked() vs find_job_locked()
functions. What's different?

1. find_block_job_locked() checks whether the found job is a block-job.
   This is OK when moving to more generic API, no needs to document this
   change.

2. find_block_job_locked() reports DeviceNotActive on failure, when
   find_job_locked() reports GenericError. So, let's document this
   difference in deprecated.txt. Still, for dismiss and finalize errors
   are not documented at all, so be silent in deprecated.txt as well.

ACKed-by: Peter Krempa <pkrempa@redhat.com>
Reviewed-by: Eric Blake <eblake@redhat.com>
Reviewed-by: Markus Armbruster <armbru@redhat.com>
Signed-off-by: Vladimir Sementsov-Ogievskiy <vsementsov@yandex-team.ru>
Message-ID: <20250409084232.28201-3-vsementsov@yandex-team.ru>
docs/about/deprecated.rst
qapi/block-core.json