]> git.ipfire.org Git - thirdparty/qemu.git/commit
hw/nvme: revert CMIC behavior
authorKlaus Jensen <k.jensen@samsung.com>
Tue, 3 Jun 2025 12:59:06 +0000 (14:59 +0200)
committerKlaus Jensen <k.jensen@samsung.com>
Mon, 11 Aug 2025 07:17:38 +0000 (00:17 -0700)
commitbc0c24fdb157b014932a5012fe4ccbeba7617f17
treef30d518c7fc7eebfe37d909c0dfad59f98eb759f
parent31b737b19dca4d50758f5e9834d27b683102f2f1
hw/nvme: revert CMIC behavior

Commit cd59f50ab017 ("hw/nvme: always initialize a subsystem") causes
the controller to always set the CMIC.MCTRS ("Multiple Controllers")
bit. While spec-compliant, this is a deviation from the previous
behavior where this was only set if an nvme-subsys device was explicitly
created (to configure a subsystem with multiple controllers/namespaces).

Revert the behavior to only set CMIC.MCTRS if an nvme-subsys device is
created explicitly.

Reported-by: Alan Adamson <alan.adamson@oracle.com>
Fixes: cd59f50ab017 ("hw/nvme: always initialize a subsystem")
Reviewed-by: Alan Adamson <alan.adamson@oracle.com>
Tested-by: Alan Adamson <alan.adamson@oracle.com>
Signed-off-by: Klaus Jensen <k.jensen@samsung.com>
hw/nvme/ctrl.c