]> git.ipfire.org Git - thirdparty/moment.git/commit
projects / thirdparty / moment.git / commit
? search:
summary | shortlog | log | commit | commitdiff | tree
(parent: 23753a5) | patch
valueOf should return NaN for any invalid moment
authorJoshua Ohlman <codewriterohs@gmail.com>
Mon, 29 Jun 2015 20:44:02 +0000 (15:44 -0500)
committerJoshua Ohlman <codewriterohs@gmail.com>
Mon, 29 Jun 2015 20:44:02 +0000 (15:44 -0500)
commitc314f03a9b7153fcab55942878a9899ad74ce73e
treec9b6566d485c6794525a9c7461873f3695ff88d6tree | snapshot
parent23753a542d5dae3b4d48d7963a48e98945817f7bcommit | diff
valueOf should return NaN for any invalid moment

this fixes an issue where isSame would return true for two invalid moments, which is inconsistent with NaN === NaN and also inconsistent with other cases where isSame would return false for two invalid moments. (some invalid moments are backed by a valid date)

Fixes #2354
src/lib/moment/to-type.js diff | blob | blame | history
src/test/moment/invalid.js diff | blob | blame | history
src/test/moment/is_same.js diff | blob | blame | history
Mirror of https://github.com/moment/moment.git