]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
net: bridge: fix ioctl old_deviceless bridge argument
authorNikolay Aleksandrov <nikolay@nvidia.com>
Thu, 5 Aug 2021 08:29:02 +0000 (11:29 +0300)
committerDavid S. Miller <davem@davemloft.net>
Thu, 5 Aug 2021 10:36:59 +0000 (11:36 +0100)
commitcbd7ad29a5070a75dd076118ce7e400ce4b8d8d1
tree4fe3e38ec93de465ef6522321db277cf4cfb6cca
parent893b195875340cb44b54c9db99e708145f1210e8
net: bridge: fix ioctl old_deviceless bridge argument

Commit ad2f99aedf8f ("net: bridge: move bridge ioctls out of .ndo_do_ioctl")
changed the source of the argument copy in bridge's old_deviceless() from
args[1] (user ptr to device name) to uarg (ptr to ioctl arguments) causing
wrong device name to be used.

Example (broken, bridge exists but is up):
$ brctl delbr bridge
bridge bridge doesn't exist; can't delete it

Example (working):
$ brctl delbr bridge
bridge bridge is still up; can't delete it

Fixes: ad2f99aedf8f ("net: bridge: move bridge ioctls out of .ndo_do_ioctl")
Signed-off-by: Nikolay Aleksandrov <nikolay@nvidia.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
net/bridge/br_ioctl.c