]> git.ipfire.org Git - thirdparty/linux.git/commit
platform/x86: int3472: Check for adev == NULL
authorHans de Goede <hdegoede@redhat.com>
Mon, 9 Dec 2024 22:05:19 +0000 (23:05 +0100)
committerIlpo Järvinen <ilpo.jarvinen@linux.intel.com>
Tue, 10 Dec 2024 13:41:20 +0000 (15:41 +0200)
commitcd2fd6eab480dfc247b737cf7a3d6b009c4d0f1c
tree5304684d95ad328b63bdc6ca413b4f8d0af72084
parentf3479920605644e273768d316aa49119ec629acc
platform/x86: int3472: Check for adev == NULL

Not all devices have an ACPI companion fwnode, so adev might be NULL. This
can e.g. (theoretically) happen when a user manually binds one of
the int3472 drivers to another i2c/platform device through sysfs.

Add a check for adev not being set and return -ENODEV in that case to
avoid a possible NULL pointer deref in skl_int3472_get_acpi_buffer().

Signed-off-by: Hans de Goede <hdegoede@redhat.com>
Link: https://lore.kernel.org/r/20241209220522.25288-1-hdegoede@redhat.com
Reviewed-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>
Signed-off-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>
drivers/platform/x86/intel/int3472/discrete.c
drivers/platform/x86/intel/int3472/tps68470.c