]> git.ipfire.org Git - thirdparty/qemu.git/commit
multifd: bugfix for migration using compression methods
authorYuan Liu <yuan1.liu@intel.com>
Wed, 18 Dec 2024 09:14:11 +0000 (17:14 +0800)
committerFabiano Rosas <farosas@suse.de>
Thu, 9 Jan 2025 20:40:15 +0000 (17:40 -0300)
commitcdc3970f8597ebdc1a4c2090cfb4d11e297329ed
tree8f28e00030fb9d7c17baed52185669b57f0c6443
parentc76ee1f6255c3988a9447d363bb17072f1ec84e1
multifd: bugfix for migration using compression methods

When compression is enabled on the migration channel and
the pages processed are all zero pages, these pages will
not be sent and updated on the target side, resulting in
incorrect memory data on the source and target sides.

The root cause is that all compression methods call
multifd_send_prepare_common to determine whether to compress
dirty pages, but multifd_send_prepare_common does not update
the IOV of MultiFDPacket_t when all dirty pages are zero pages.

The solution is to always update the IOV of MultiFDPacket_t
regardless of whether the dirty pages are all zero pages.

Fixes: 303e6f54f9 ("migration/multifd: Implement zero page transmission on the multifd thread.")
Cc: qemu-stable@nongnu.org #9.0+
Signed-off-by: Yuan Liu <yuan1.liu@intel.com>
Reviewed-by: Jason Zeng <jason.zeng@intel.com>
Reviewed-by: Peter Xu <peterx@redhat.com>
Message-Id: <20241218091413.140396-2-yuan1.liu@intel.com>
Signed-off-by: Fabiano Rosas <farosas@suse.de>
migration/multifd-nocomp.c