]> git.ipfire.org Git - thirdparty/Python/cpython.git/commit
bpo-32270: Don't close stdin/out/err in pass_fds (GH-6242)
authorGregory P. Smith <greg@krypto.org>
Tue, 11 Sep 2018 00:46:22 +0000 (17:46 -0700)
committerGitHub <noreply@github.com>
Tue, 11 Sep 2018 00:46:22 +0000 (17:46 -0700)
commitce34410b8b67f49d8275c05d51b3ead50cf97f48
tree08e99370a122056aa4101d670e505217961c4058
parent880d42a3b247306f67837aa95e23f7c3471a30a3
bpo-32270: Don't close stdin/out/err in pass_fds (GH-6242)

When subprocess.Popen() stdin= stdout= or stderr= handles are specified
and appear in pass_fds=, don't close the original fds after dup'ing them.

This implementation and unittest primarily came from @izbyshev (see the PR)

See also https://github.com/izbyshev/cpython/commit/b89b52f28490b69142d5c061604b3a3989cec66c

This also removes the old manual p2cread, c2pwrite, and errwrite closing logic
as inheritable flags and _close_open_fds takes care of that properly today without special treatment.

This code is within child_exec() where it is the only thread so there is no
race condition between the dup and _Py_set_inheritable_async_safe call.
Lib/test/test_subprocess.py
Misc/NEWS.d/next/Library/2018-09-10-14-15-53.bpo-32270.wSJjuD.rst [new file with mode: 0644]
Modules/_posixsubprocess.c