]> git.ipfire.org Git - thirdparty/Python/cpython.git/commit
gh-108973: Fix asyncio test_subprocess_consistent_callbacks() (#109431)
authorVictor Stinner <vstinner@python.org>
Wed, 20 Sep 2023 13:54:19 +0000 (15:54 +0200)
committerGitHub <noreply@github.com>
Wed, 20 Sep 2023 13:54:19 +0000 (15:54 +0200)
commitced6924630037f1e5b3d1dbef2b600152fb07fbb
tree9dd1a37eb08179229e59319f3feba36161325486
parent850cc8d0b1db0a912a6e458720e265e6a6e5c1ba
gh-108973: Fix asyncio test_subprocess_consistent_callbacks() (#109431)

SubprocessProtocol process_exited() method can be called before
pipe_data_received() and pipe_connection_lost() methods. Document it
and adapt the test for that.

Revert commit 282edd7b2a74c4dfe1bfe3c5b1d30f9c21d554d6.
_child_watcher_callback() calls immediately _process_exited(): don't
add an additional delay with call_soon(). The reverted change didn't
make _process_exited() more determistic: it can still be called
before pipe_connection_lost() for example.

Co-authored-by: Davide Rizzo <sorcio@gmail.com>
Doc/library/asyncio-llapi-index.rst
Doc/library/asyncio-protocol.rst
Lib/asyncio/unix_events.py
Lib/test/test_asyncio/test_subprocess.py