]> git.ipfire.org Git - thirdparty/curl.git/commit
cookies: using a share with cookies shouldn't enable the cookie engine
authorDaniel Stenberg <daniel@haxx.se>
Fri, 27 Sep 2019 07:41:43 +0000 (09:41 +0200)
committerDaniel Stenberg <daniel@haxx.se>
Sat, 28 Sep 2019 16:10:43 +0000 (18:10 +0200)
commitd0a7ee3f613b0c3f2370c6cc81e5aafef67120f0
tree84313021ed566a898a897112ddc7982e2e89a00d
parented735091574122fd5b2f5bac1edc56d5f03aa969
cookies: using a share with cookies shouldn't enable the cookie engine

The 'share object' only sets the storage area for cookies. The "cookie
engine" still needs to be enabled or activated using the normal cookie
options.

This caused the curl command line tool to accidentally use cookies
without having been told to, since curl switched to using shared cookies
in 7.66.0.

Test 1166 verifies

Updated test 506

Fixes #4429
Closes #4434
lib/cookie.c
lib/http.c
lib/urldata.h
tests/data/Makefile.inc
tests/data/test1166 [new file with mode: 0644]
tests/data/test506
tests/libtest/lib506.c