]> git.ipfire.org Git - thirdparty/qemu.git/commit
target/hppa: Fix random 32-bit linux-user crashes
authorHelge Deller <deller@gmx.de>
Tue, 3 Sep 2024 16:21:28 +0000 (18:21 +0200)
committerHelge Deller <deller@gmx.de>
Tue, 3 Sep 2024 20:08:22 +0000 (22:08 +0200)
commitd33d3adb573794903380e03e767e06470514cefe
treee4b625d9a12bde63c0d0a7ada531f9563794b5ed
parentead5078cf1a5f11d16e3e8462154c859620bcc7e
target/hppa: Fix random 32-bit linux-user crashes

The linux-user hppa target crashes randomly for me since commit
081a0ed188d8 ("target/hppa: Do not mask in copy_iaoq_entry").

That commit dropped the masking of the IAOQ addresses while copying them
from other registers and instead keeps them with all 64 bits up until
the full gva is formed with the help of hppa_form_gva_psw().

So, when running in linux-user mode on an emulated 64-bit CPU, we need
to mask to a 32-bit address space at the very end in hppa_form_gva_psw()
if the PSW-W flag isn't set (which is the case for linux-user on hppa).

Fixes: 081a0ed188d8 ("target/hppa: Do not mask in copy_iaoq_entry")
Cc: qemu-stable@nongnu.org # v9.1+
Signed-off-by: Helge Deller <deller@gmx.de>
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
target/hppa/cpu.h