]> git.ipfire.org Git - thirdparty/shadow.git/commit
tests/: Support run_some from exported tarball
authorSerge Hallyn <serge@hallyn.com>
Sat, 25 May 2024 13:40:11 +0000 (08:40 -0500)
committerAlejandro Colomar <alx@kernel.org>
Wed, 26 Jun 2024 21:59:07 +0000 (23:59 +0200)
commitd55367bb161b04f65fbb0abbd8c98793e79d3d03
treecc72846ce7c386918208c0983c21615d33057064
parent47edcd3045fd2865cbcdcb002f52195a960b3dda
tests/: Support run_some from exported tarball

common/config.sh currently tries to find the top directory by looking
for .git.  There are also many places under tests/ where we use
hard-coded ../../.. to find things like ${TOP_DIR}/lib.

We don't actually ship the tests with 'make dist'.  So we will
be exporting tests/ as a separate tarball.  In particular, I want
to then import this in the debian package.  However, there it will
be under shadow.git/debian/tests, not shadow.git/tests.

To support this, accept the environment variable BUILD_BASE_DIR,
which should point to shadow.git.

An alternative would be to move the tests to their own git
tree.  However, keeping tests in separate git tree tends to
lead to repos getting out of sync.  And we'd still need to accept
something like BUILD_BASE_DIR.

Note there are a lot of tests under run-all, which I'm not converting
as they currently are not being run in CI, so I'm more likely to
break something.

Changelog:
  2024 05 26: Incorporate feedback from alejandro-colomar

Link: <https://salsa.debian.org/debian/shadow/-/merge_requests/21>
Link: <https://salsa.debian.org/debian/shadow/-/merge_requests/22>
Cc: Chris Hofstaedtler <zeha@debian.org>
Signed-off-by: Serge Hallyn <serge@hallyn.com>
Signed-off-by: Alejandro Colomar <alx@kernel.org>
tests/common/config.sh
tests/libsubid/04_nss/Makefile
tests/libsubid/04_nss/subidnss.test
tests/libsubid/04_nss/test_range