]> git.ipfire.org Git - thirdparty/qemu.git/commit
block/pflash_cfi02: Fix memory leak and potential use-after-free
authorStephen Checkoway <stephen.checkoway@oberlin.edu>
Tue, 19 Feb 2019 15:37:27 +0000 (10:37 -0500)
committerLaurent Vivier <laurent@vivier.eu>
Wed, 6 Mar 2019 09:37:23 +0000 (10:37 +0100)
commitd80cf1eb2e87df3a9bfb226bcc7fb3a1aa858817
tree6b059a4fc081834da97ba72aac30330d8c274321
parent7d9b68acb37059bee347ce7e4c783ca5b7cf7ae0
block/pflash_cfi02: Fix memory leak and potential use-after-free

Don't dynamically allocate the pflash's timer. But do use timer_del in
an unrealize function to make sure that the timer can't fire after the
pflash_t has been freed.

Signed-off-by: Stephen Checkoway <stephen.checkoway@oberlin.edu>
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Reviewed-by: Wei Yang <richardw.yang@linux.intel.com>
Message-Id: <20190219153727.62279-1-stephen.checkoway@oberlin.edu>
Signed-off-by: Laurent Vivier <laurent@vivier.eu>
hw/block/pflash_cfi02.c