]> git.ipfire.org Git - thirdparty/suricata.git/commit
output/log: Remove extraneous error message
authorJeff Lucovsky <jlucovsky@oisf.net>
Thu, 12 Dec 2024 13:49:20 +0000 (08:49 -0500)
committerVictor Julien <victor@inliniac.net>
Sat, 4 Jan 2025 18:35:24 +0000 (19:35 +0100)
commitd853972c744c789abbb61fa8e2fb567f4f6456ec
tree78852187c7d7281337b46c3bbeaee8128bad2ede
parente72fc39f831e5c03d7884caa447eb758a345d1c8
output/log: Remove extraneous error message

Issue: 7447

When the output file can't be opened, 2 error messages are displayed
for the same problem. The second message doesn't add value and lacks
context (error reason, e.g., "Permission denied").

Retaining the second message as a debug message.

Without this commit:

Error: logopenfile: Error opening file: "/home/jlucovsky/src/jal/suricata-verify/tests/bug-5198/output/noperms/eve.1.json": Permission denied [SCLogOpenFileFp:util-logopenfile.c:428]
Error: logopenfile: Unable to open slot 1 for file /home/jlucovsky/src/jal/suricata-verify/tests/bug-5198/output/noperms/eve.json [LogFileEnsureExists:util-logopenfile.c:737]
Error: runmodes: unable to initialize sub-module eve-log.stats [RunModeInitializeEveOutput:runmodes.c:692]

With commit:

Error: logopenfile: Error opening file: "/home/jlucovsky/src/jal/suricata-verify/tests/bug-5198/output/noperms/eve.1.json": Permission denied [SCLogOpenFileFp:util-logopenfile.c:428]
Error: runmodes: unable to initialize sub-module eve-log.stats [RunModeInitializeEveOutput:runmodes.c:692]
src/util-logopenfile.c