]> git.ipfire.org Git - thirdparty/Python/cpython.git/commit
gh-136396: Include instrumentation when creating new copies of the bytecode (#136525)
authormpage <mpage@meta.com>
Mon, 14 Jul 2025 17:48:10 +0000 (10:48 -0700)
committerGitHub <noreply@github.com>
Mon, 14 Jul 2025 17:48:10 +0000 (10:48 -0700)
commitd995922198304a6de19ac1bec3e36d1e886d8468
treec0391deb15a6c39c05c2fee1f78cdca98b5f3379
parent3d8c38f6db0fea7845aafb92fe6bc795b536a367
gh-136396: Include instrumentation when creating new copies of the bytecode (#136525)

Previously, we assumed that instrumentation would happen for all copies of
the bytecode if the instrumentation version on the code object didn't match
the per-interpreter instrumentation version. That assumption was incorrect:
instrumentation will exit early if there are no new "events," even if there
is an instrumentation version mismatch.

To fix this, include the instrumented opcodes when creating new copies of
the bytecode, rather than replacing them with their uninstrumented variants.
I don't think we have to worry about races between instrumentation and creating
new copies of the bytecode: instrumentation and new bytecode creation cannot happen
concurrently. Instrumentation requires that either the world is stopped or the
code object's per-object lock is held and new bytecode creation requires holding
the code object's per-object lock.
Lib/test/test_free_threading/test_monitoring.py
Misc/NEWS.d/next/Core_and_Builtins/2025-07-10-15-53-16.gh-issue-136525.xAko0e.rst [new file with mode: 0644]
Objects/codeobject.c