]> git.ipfire.org Git - thirdparty/git.git/commit
t/test-lib: wire up NO_ICONV prerequisite
authorPatrick Steinhardt <ps@pks.im>
Wed, 16 Oct 2024 08:12:53 +0000 (10:12 +0200)
committerTaylor Blau <me@ttaylorr.com>
Wed, 16 Oct 2024 21:00:49 +0000 (17:00 -0400)
commitdf383b584267d3b7b57fb513bef4a2ff8eb8fe30
treef2ffe2b4c22060ad1042537c687c9e3984e06a84
parented7634ebcc0cbfb229bc0bf2c74cd3ef4060c096
t/test-lib: wire up NO_ICONV prerequisite

The iconv library is used by Git to reencode files, commit messages and
other things. As such it is a rather integral part, but given that many
platforms nowadays use UTF-8 everywhere you can live without support for
reencoding in many situations. It is thus optional to build Git with
iconv, and some of our platforms wired up in "config.mak.uname" disable
it. But while we support building without it, running our test suite
with "NO_ICONV=Yes" causes many test failures.

Wire up a new test prerequisite ICONV that gets populated via our
GIT-BUILD-OPTIONS. Annotate failing tests accordingly.

Note that this commit does not do a deep dive into every single test to
assess whether the failure is expected or not. Most of the tests do
smell like the expected kind of failure though.

Signed-off-by: Patrick Steinhardt <ps@pks.im>
Signed-off-by: Taylor Blau <me@ttaylorr.com>
22 files changed:
Makefile
contrib/buildsystems/CMakeLists.txt
t/t0028-working-tree-encoding.sh
t/t2082-parallel-checkout-attributes.sh
t/t3434-rebase-i18n.sh
t/t3900-i18n-commit.sh
t/t3901-i18n-patch.sh
t/t4041-diff-submodule-option.sh
t/t4059-diff-submodule-not-initialized.sh
t/t4060-diff-submodule-option-diff-format.sh
t/t4201-shortlog.sh
t/t4205-log-pretty-formats.sh
t/t4210-log-i18n.sh
t/t4254-am-corrupt.sh
t/t5100-mailinfo.sh
t/t5550-http-fetch-dumb.sh
t/t6006-rev-list-format.sh
t/t7102-reset.sh
t/t8005-blame-i18n.sh
t/t9300-fast-import.sh
t/t9350-fast-export.sh
t/test-lib.sh