]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
projects / thirdparty / kernel / stable.git / commit
? search:
summary | shortlog | log | commit | commitdiff | tree
(parent: 39e88fc) | patch
nfs: fix null checking in nfs_get_option_str()
authorXi Wang <xi.wang@gmail.com>
Fri, 4 Jan 2013 08:22:57 +0000 (03:22 -0500)
committerTrond Myklebust <Trond.Myklebust@netapp.com>
Fri, 4 Jan 2013 15:54:43 +0000 (10:54 -0500)
commite25fbe380c4e3c09afa98bcdcd9d3921443adab8
tree91aeee4cfe6cfa4a07e2373d7d1f4d3d65b0b549tree | snapshot
parent39e88fcfb1d5c6c4b1ff76ca2ab76cf449b850e8commit | diff
nfs: fix null checking in nfs_get_option_str()

The following null pointer check is broken.

*option = match_strdup(args);
return !option;

The pointer `option' must be non-null, and thus `!option' is always false.
Use `!*option' instead.

The bug was introduced in commit c5cb09b6f8 ("Cleanup: Factor out some
cut-and-paste code.").

Signed-off-by: Xi Wang <xi.wang@gmail.com>
Cc: stable@vger.kernel.org
Signed-off-by: Trond Myklebust <Trond.Myklebust@netapp.com>
fs/nfs/super.c diff | blob | blame | history
Mirror https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git