]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
iio: accel: mma9551_core: Prevent uninitialized variable in mma9551_read_status_word()
authorHarshit Mogalapalli <harshit.m.mogalapalli@oracle.com>
Thu, 26 Jan 2023 15:21:46 +0000 (07:21 -0800)
committerJonathan Cameron <Jonathan.Cameron@huawei.com>
Sat, 28 Jan 2023 17:37:08 +0000 (17:37 +0000)
commite56d2c34ce9dc122b1a618172ec0e05e50adb9e9
tree36e08da148dd401e2725cebbbcf8a99ccb4d2a6c
parentb186b18efdff219002298f3d87714cf5784b1926
iio: accel: mma9551_core: Prevent uninitialized variable in mma9551_read_status_word()

Smatch Warns: drivers/iio/accel/mma9551_core.c:357
mma9551_read_status_word() error: uninitialized symbol 'v'.

When (offset >= 1 << 12) is true mma9551_transfer() will return -EINVAL
without 'v' being initialized, so check for the error and return.

Note: Not a bug as such because the caller checks return value and
doesn't not use this parameter in the problem case.

Signed-off-by: Harshit Mogalapalli <harshit.m.mogalapalli@oracle.com>
Link: https://lore.kernel.org/r/20230126152147.3585874-1-harshit.m.mogalapalli@oracle.com
Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
drivers/iio/accel/mma9551_core.c