]> git.ipfire.org Git - thirdparty/glibc.git/commit
elf: Testing infrastructure for ld.so DSO sorting (BZ #17645)
authorChung-Lin Tang <cltang@codesourcery.com>
Thu, 21 Oct 2021 13:41:21 +0000 (21:41 +0800)
committerAdhemerval Zanella <adhemerval.zanella@linaro.org>
Thu, 21 Oct 2021 14:23:53 +0000 (11:23 -0300)
commite6fd79f3795d46dfb583e124be49fc063bc3d58b
tree1d2b1f6ac65243c5f3e8f9c5283ec14751d136a7
parent0ff2d30daedb6d0d00401f1f2a48a80ff99d7c25
elf: Testing infrastructure for ld.so DSO sorting (BZ #17645)

This is the first of a 2-part patch set that fixes slow DSO sorting behavior in
the dynamic loader, as reported in BZ #17645. In order to facilitate such a
large modification to the dynamic loader, this first patch implements a testing
framework for validating shared object sorting behavior, to enable comparison
between old/new sorting algorithms, and any later enhancements.

This testing infrastructure consists of a Python script
scripts/dso-ordering-test.py' which takes in a description language, consisting
of strings that describe a set of link dependency relations between DSOs, and
generates testcase programs and Makefile fragments to automatically test the
described situation, for example:

  a->b->c->d          # four objects linked one after another

  a->[bc]->d;b->c     # a depends on b and c, which both depend on d,
                      # b depends on c (b,c linked to object a in fixed order)

  a->b->c;{+a;%a;-a}  # a, b, c serially dependent, main program uses
                      # dlopen/dlsym/dlclose on object a

  a->b->c;{}!->[abc]  # a, b, c serially dependent; multiple tests generated
                      # to test all permutations of a, b, c ordering linked
                      # to main program

 (Above is just a short description of what the script can do, more
  documentation is in the script comments.)

Two files containing several new tests, elf/dso-sort-tests-[12].def are added,
including test scenarios for BZ #15311 and Redhat issue #1162810 [1].

Due to the nature of dynamic loader tests, where the sorting behavior and test
output occurs before/after main(), generating testcases to use
support/test-driver.c does not suffice to control meaningful timeout for ld.so.
Therefore a new utility program 'support/test-run-command', based on
test-driver.c/support_test_main.c has been added. This does the same testcase
control, but for a program specified through a command-line rather than at the
source code level. This utility is used to run the dynamic loader testcases
generated by dso-ordering-test.py.

[1] https://bugzilla.redhat.com/show_bug.cgi?id=1162810

Signed-off-by: Chung-Lin Tang <cltang@codesourcery.com>
Reviewed-by: Adhemerval Zanella <adhemerval.zanella@linaro.org>
elf/Makefile
elf/dso-sort-tests-1.def [new file with mode: 0644]
elf/dso-sort-tests-2.def [new file with mode: 0644]
scripts/dso-ordering-test.py [new file with mode: 0644]
support/Depend [new file with mode: 0644]
support/Makefile
support/support_test_main.c
support/test-driver.c
support/test-driver.h
support/test-run-command.c [new file with mode: 0644]