]> git.ipfire.org Git - thirdparty/qemu.git/commit
net: move backend cleanup to NIC cleanup
authorEugenio Pérez <eperezma@redhat.com>
Mon, 6 Jan 2025 15:57:35 +0000 (10:57 -0500)
committerJason Wang <jasowang@redhat.com>
Mon, 10 Mar 2025 09:07:16 +0000 (17:07 +0800)
commite7891c575fb294618b172119a91c892b8f4384a2
tree47a44c0c697ec06b9dc7ff117608a161a4ed43f5
parentdb0d4017f9b9e87f962b35dd19a4912bbfcd3cbc
net: move backend cleanup to NIC cleanup

Commit a0d7215e33 ("vhost-vdpa: do not cleanup the vdpa/vhost-net
structures if peer nic is present") effectively delayed the backend
cleanup, allowing the frontend or the guest to access it resources as
long as the frontend is still visible to the guest.

However it does not clean up the resources until the qemu process is
over.  This causes an effective leak if the device is deleted with
device_del, as there is no way to close the vdpa device.  This makes
impossible to re-add that device to this or other QEMU instances until
the first instance of QEMU is finished.

Move the cleanup from qemu_cleanup to the NIC deletion and to
net_cleanup.

Fixes: a0d7215e33 ("vhost-vdpa: do not cleanup the vdpa/vhost-net structures if peer nic is present")
Reported-by: Lei Yang <leiyang@redhat.com>
Signed-off-by: Eugenio Pérez <eperezma@redhat.com>
Signed-off-by: Jonah Palmer <jonah.palmer@oracle.com>
Signed-off-by: Jason Wang <jasowang@redhat.com>
net/net.c
net/vhost-vdpa.c