]> git.ipfire.org Git - thirdparty/squid.git/commit
Restore errno in %err_detail for ERR_CONNECT_FAIL (#1368)
authorAlex Rousskov <rousskov@measurement-factory.com>
Fri, 8 Sep 2023 06:05:36 +0000 (06:05 +0000)
committerSquid Anubis <squid-anubis@squid-cache.org>
Fri, 8 Sep 2023 06:05:45 +0000 (06:05 +0000)
commitea3f56e21ee0d7dd570092cabe23161b363f8cec
tree88ebfe544ce4534db7a5b390ca72566ac77e0219
parent8d3bf70e6447b82380e1270a1cfa0096d4761614
Restore errno in %err_detail for ERR_CONNECT_FAIL (#1368)

Squid was sometimes logging %err_code/%err_detail as
ERR_CONNECT_FAIL/WITH_SERVER. It now logs
ERR_CONNECT_FAIL/WITH_SERVER+errno=111 (or similar).

When dealing with two error details, Squid was ignoring the latter one.
The new ErrorDetails code combines multiple details, reusing the
existing Security::ErrorDetail::brief() "a+b+c" syntax.

The new detail accumulation functionality may help detail other errors.

At least some of the logged errno details were lost in commit ba3fe8d.
src/base/IoManip.h
src/cf.data.pre
src/client_side.cc
src/error/Detail.h
src/error/Error.cc
src/error/Error.h
src/errorpage.cc
src/format/Format.cc
src/servers/FtpServer.cc
src/tests/stub_liberror.cc