]> git.ipfire.org Git - people/arne_f/kernel.git/commit
leds: 88pm860x: fix use-after-free on unbind
authorJohan Hovold <johan@kernel.org>
Mon, 1 Jun 2020 13:39:45 +0000 (15:39 +0200)
committerPavel Machek <pavel@ucw.cz>
Mon, 22 Jun 2020 08:37:58 +0000 (10:37 +0200)
commiteca21c2d8655387823d695b26e6fe78cf3975c05
tree0c9beb613a884d6bee0bf9a1330126ce71d5beda
parent985b1f596f9ed56f42b8c2280005f943e1434c06
leds: 88pm860x: fix use-after-free on unbind

Several MFD child drivers register their class devices directly under
the parent device. This means you cannot blindly do devres conversions
so that deregistration ends up being tied to the parent device,
something which leads to use-after-free on driver unbind when the class
device is released while still being registered.

Fixes: 375446df95ee ("leds: 88pm860x: Use devm_led_classdev_register")
Cc: stable <stable@vger.kernel.org> # 4.6
Cc: Amitoj Kaur Chawla <amitoj1606@gmail.com>
Signed-off-by: Johan Hovold <johan@kernel.org>
Signed-off-by: Pavel Machek <pavel@ucw.cz>
drivers/leds/leds-88pm860x.c