]> git.ipfire.org Git - thirdparty/glibc.git/commit
Avoid backtrace from __stack_chk_fail [BZ #12189]
authorH.J. Lu <hjl.tools@gmail.com>
Tue, 11 Jul 2017 14:44:01 +0000 (07:44 -0700)
committerH.J. Lu <hjl.tools@gmail.com>
Tue, 11 Jul 2017 14:44:14 +0000 (07:44 -0700)
commited421fca42fd9b4cab7c66e77894b8dd7ca57ed0
treef1131793bd3340ada62e6d31434e1d8003eec2fd
parent94070f86c0c849c71ed2e7e2189bb4d1f7411a17
Avoid backtrace from __stack_chk_fail [BZ #12189]

__stack_chk_fail is called on corrupted stack.  Stack backtrace is very
unreliable against corrupted stack.  __libc_message is changed to accept
enum __libc_message_action and call BEFORE_ABORT only if action includes
do_backtrace.  __fortify_fail_abort is added to avoid backtrace from
__stack_chk_fail.

[BZ #12189]
* debug/Makefile (CFLAGS-tst-ssp-1.c): New.
(tests): Add tst-ssp-1 if -fstack-protector works.
* debug/fortify_fail.c: Include <stdbool.h>.
(_fortify_fail_abort): New function.
(__fortify_fail): Call _fortify_fail_abort.
(__fortify_fail_abort): Add a hidden definition.
* debug/stack_chk_fail.c: Include <stdbool.h>.
(__stack_chk_fail): Call __fortify_fail_abort, instead of
__fortify_fail.
* debug/tst-ssp-1.c: New file.
* include/stdio.h (__libc_message_action): New enum.
(__libc_message): Replace int with enum __libc_message_action.
(__fortify_fail_abort): New hidden prototype.
* malloc/malloc.c (malloc_printerr): Update __libc_message calls.
* sysdeps/posix/libc_fatal.c (__libc_message): Replace int
with enum __libc_message_action.  Call BEFORE_ABORT only if
action includes do_backtrace.
(__libc_fatal): Update __libc_message call.
ChangeLog
debug/Makefile
debug/fortify_fail.c
debug/stack_chk_fail.c
debug/tst-ssp-1.c [new file with mode: 0644]
include/stdio.h
malloc/malloc.c
sysdeps/posix/libc_fatal.c