]> git.ipfire.org Git - thirdparty/openvpn.git/commit
Eliminate or comment empty blocks and switch fallthrough
authorArne Schwabe <arne@rfc2549.org>
Thu, 15 Dec 2022 19:01:40 +0000 (20:01 +0100)
committerGert Doering <gert@greenie.muc.de>
Fri, 16 Dec 2022 17:10:18 +0000 (18:10 +0100)
commitf2454ec6363d5578875d020179b38074b3c10964
treea7a6493892fcf0fceba62321241e860716b6a95b
parent4b6854881c36e16054878e0467ef87d925e20cae
Eliminate or comment empty blocks and switch fallthrough

These empty blocks are intentional but trigger code checkers and
were pointed out by Trail of Bits in the security audits. Add comments
to them or eliminate them whatever makes more sense.

For fallthrough C23 [1] has a standard way to signal that but we not
adding a C23 feature to our codebase, so use a comment for now.

[1] https://en.cppreference.com/w/c/language/attributes/fallthrough

Signed-off-by: Arne Schwabe <arne@rfc2549.org>
Acked-by: Gert Doering <gert@greenie.muc.de>
Message-Id: <20221215190143.2107896-6-arne@rfc2549.org>
URL: https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg25735.html
Signed-off-by: Gert Doering <gert@greenie.muc.de>
src/openvpn/comp-lz4.c
src/openvpn/crypto.c
src/openvpn/init.c
src/openvpn/lzo.c
src/openvpn/options.c
src/openvpn/ssl_openssl.c