]> git.ipfire.org Git - thirdparty/kernel/linux.git/commit
net: rfs: hash function change
authorEric Dumazet <edumazet@google.com>
Fri, 21 Mar 2025 17:13:09 +0000 (17:13 +0000)
committerJakub Kicinski <kuba@kernel.org>
Tue, 25 Mar 2025 15:24:13 +0000 (08:24 -0700)
commitf3483c8e1da62993fe0f57af23b925de7661adaa
tree3d864c054b3ebe3c8eecda735e3b235851214994
parent1952e19c02ae8ea0c663d30b19be14344b543068
net: rfs: hash function change

RFS is using two kinds of hash tables.

First one is controlled by /proc/sys/net/core/rps_sock_flow_entries = 2^N
and using the N low order bits of the l4 hash is good enough.

Then each RX queue has its own hash table, controlled by
/sys/class/net/eth1/queues/rx-$q/rps_flow_cnt = 2^X

Current hash function, using the X low order bits is suboptimal,
because RSS is usually using Func(hash) = (hash % power_of_two);

For example, with 32 RX queues, 6 low order bits have no entropy
for a given queue.

Switch this hash function to hash_32(hash, log) to increase
chances to use all possible slots and reduce collisions.

Signed-off-by: Eric Dumazet <edumazet@google.com>
Cc: Tom Herbert <tom@herbertland.com>
Reviewed-by: Simon Horman <horms@kernel.org>
Link: https://patch.msgid.link/20250321171309.634100-1-edumazet@google.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
include/net/rps.h
net/core/dev.c
net/core/net-sysfs.c