]> git.ipfire.org Git - thirdparty/linux.git/commit
nvme: fix atomic write size validation
authorChristoph Hellwig <hch@lst.de>
Wed, 11 Jun 2025 04:54:56 +0000 (06:54 +0200)
committerChristoph Hellwig <hch@lst.de>
Thu, 26 Jun 2025 11:04:37 +0000 (13:04 +0200)
commitf46d273449ba65afd53f3dd8fe0182c9df877e08
treed5b536087c50808dac01a8e9946938d64fad2cf3
parentb2e607fecac15e07f50269c080e2e71b5049dfa2
nvme: fix atomic write size validation

Don't mix the namespace and controller values, and validate the
per-controller limit when probing the controller.  This avoid spurious
failures for controllers with namespaces that have different namespaces
with different logical block sizes, or report the per-namespace values
only for some namespaces.

It also fixes a missing queue_limits_cancel_update in an error path by
removing that error path.

Fixes: 8695f060a029 ("nvme: all namespaces in a subsystem must adhere to a common atomic write size")
Reported-by: Yi Zhang <yi.zhang@redhat.com>
Signed-off-by: Christoph Hellwig <hch@lst.de>
Reviewed-by: Luis Chamberlain <mcgrof@kernel.org>
Reviewed-by: John Garry <john.g.garry@oracle.com>
Tested-by: Yi Zhang <yi.zhang@redhat.com>
drivers/nvme/host/core.c
drivers/nvme/host/nvme.h