]> git.ipfire.org Git - thirdparty/qemu.git/commit
hw/nvme: fix missing cq eventidx update
authorKlaus Jensen <k.jensen@samsung.com>
Thu, 8 Dec 2022 08:12:45 +0000 (09:12 +0100)
committerKlaus Jensen <k.jensen@samsung.com>
Mon, 9 Jan 2023 07:48:46 +0000 (08:48 +0100)
commitfa5db2aa168bdc0f15c269b6212ef47632fab8ba
tree59dd93900b5cf84801640abcc4bce4478db19a15
parent2fda0726e5149e032acfa5fe442db56cd6433c4c
hw/nvme: fix missing cq eventidx update

Prior to reading the shadow doorbell cq head, we have to update the
eventidx. Otherwise, we risk that the driver will skip an mmio doorbell
write. This happens on riscv64, as reported by Guenter.

Adding the missing update to the cq eventidx fixes the issue.

Fixes: 3f7fe8de3d49 ("hw/nvme: Implement shadow doorbell buffer support")
Cc: qemu-stable@nongnu.org
Cc: qemu-riscv@nongnu.org
Reported-by: Guenter Roeck <linux@roeck-us.net>
Reviewed-by: Keith Busch <kbusch@kernel.org>
Signed-off-by: Klaus Jensen <k.jensen@samsung.com>
hw/nvme/ctrl.c