]> git.ipfire.org Git - thirdparty/qemu.git/commit
target/arm: take HSTR traps of cp15 accesses to EL2, not EL1
authorPeter Maydell <peter.maydell@linaro.org>
Tue, 2 Apr 2024 08:54:41 +0000 (09:54 +0100)
committerPeter Maydell <peter.maydell@linaro.org>
Tue, 2 Apr 2024 08:54:41 +0000 (09:54 +0100)
commitfbe5ac5671a9cfcc7f4aee9a5fac7720eea08876
tree316106edb6d81e9656e626eca7c94a7b8b48bbb2
parent6af9d12c88b9720f209912f6e4b01fefe5906d59
target/arm: take HSTR traps of cp15 accesses to EL2, not EL1

The HSTR_EL2 register allows the hypervisor to trap AArch32 EL1 and
EL0 accesses to cp15 registers.  We incorrectly implemented this so
they trap to EL1 when we detect the need for a HSTR trap at code
generation time.  (The check in access_check_cp_reg() which we do at
runtime to catch traps from EL0 is correctly routing them to EL2.)

Use the correct target EL when generating the code to take the trap.

Cc: qemu-stable@nongnu.org
Resolves: https://gitlab.com/qemu-project/qemu/-/issues/2226
Fixes: 049edada5e93df ("target/arm: Make HSTR_EL2 traps take priority over UNDEF-at-EL1")
Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
Message-id: 20240325133116.2075362-1-peter.maydell@linaro.org
target/arm/tcg/translate.c