]> git.ipfire.org Git - thirdparty/qemu.git/commit
numa: properly check if numa is supported
authorIgor Mammedov <imammedo@redhat.com>
Thu, 12 Dec 2019 12:48:56 +0000 (13:48 +0100)
committerEduardo Habkost <ehabkost@redhat.com>
Thu, 19 Dec 2019 17:57:14 +0000 (14:57 -0300)
commitfcd3f2cc124600385dba46c69a80626985c15b50
tree0316877273e7dec801843ec23f9e1f9f263c6c67
parent5275db59aa7ff8a26bd6aa5d07cb4d53de5cfab5
numa: properly check if numa is supported

Commit aa57020774b, by mistake used MachineClass::numa_mem_supported
to check if NUMA is supported by machine and also as unrelated change
set it to true for sbsa-ref board.

Luckily change didn't break machines that support NUMA, as the field
is set to true for them.

But the field is not intended for checking if NUMA is supported and
will be flipped to false within this release for new machine types.

Fix it:
 - by using previously used condition
      !mc->cpu_index_to_instance_props || !mc->get_default_cpu_node_id
   the first time and then use MachineState::numa_state down the road
   to check if NUMA is supported
 - dropping stray sbsa-ref chunk

Fixes: aa57020774b690a22be72453b8e91c9b5a68c516
Signed-off-by: Igor Mammedov <imammedo@redhat.com>
Message-Id: <1576154936-178362-3-git-send-email-imammedo@redhat.com>
Signed-off-by: Eduardo Habkost <ehabkost@redhat.com>
hw/arm/sbsa-ref.c
hw/core/machine.c