]> git.ipfire.org Git - thirdparty/kernel/linux.git/commit
ipv4: icmp: fix null-ptr-deref in icmp_build_probe()
authorYiqi Sun <sunyiqixm@gmail.com>
Thu, 2 Apr 2026 07:04:19 +0000 (15:04 +0800)
committerJakub Kicinski <kuba@kernel.org>
Fri, 3 Apr 2026 22:46:17 +0000 (15:46 -0700)
commitfde29fd9349327acc50d19a0b5f3d5a6c964dfd8
tree0f0e7766f3f46d737d42f50011b10e4a5c467a44
parent14cf0cd35361f4e94824bf8a42f72713d7702a73
ipv4: icmp: fix null-ptr-deref in icmp_build_probe()

ipv6_stub->ipv6_dev_find() may return ERR_PTR(-EAFNOSUPPORT) when the
IPv6 stack is not active (CONFIG_IPV6=m and not loaded), and passing
this error pointer to dev_hold() will cause a kernel crash with
null-ptr-deref.

Instead, silently discard the request. RFC 8335 does not appear to
define a specific response for the case where an IPv6 interface
identifier is syntactically valid but the implementation cannot perform
the lookup at runtime, and silently dropping the request may safer than
misreporting "No Such Interface".

Fixes: d329ea5bd884 ("icmp: add response to RFC 8335 PROBE messages")
Signed-off-by: Yiqi Sun <sunyiqixm@gmail.com>
Link: https://patch.msgid.link/20260402070419.2291578-1-sunyiqixm@gmail.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
net/ipv4/icmp.c