]> git.ipfire.org Git - thirdparty/gcc.git/commit
IFCVT: Fix factor_out_operators correctly for more than 1 phi [PR121295]
authorAndrew Pinski <quic_apinski@quicinc.com>
Tue, 29 Jul 2025 15:46:01 +0000 (08:46 -0700)
committerAndrew Pinski <quic_apinski@quicinc.com>
Wed, 30 Jul 2025 15:19:07 +0000 (08:19 -0700)
commitaebbc90d8c7c703c787ce402b9c55fdf2ecbbcd8
tree3b594dabb4f863658f141513ceb3dcf857dab110
parent0ab20ee0eae1c4556fbade6dd6ea896f00cf0128
IFCVT: Fix factor_out_operators correctly for more than 1 phi [PR121295]

r16-2590-ga51bf9e10182cf was not the correct fix for this in the end.
Instead a much simplier and localized fix is needed, just change the phi
that is being worked on with the new result and arguments that is from the
factored out operator.
This solves the issue of not having result in the IR and causing issues that way.

Bootstrapped and tested on x86_64-linux-gnu.
Note this depends on reverting r16-2590-ga51bf9e10182cf.

PR tree-optimization/121236
PR tree-optimization/121295

gcc/ChangeLog:

* tree-if-conv.cc (factor_out_operators): Change the phi node
to the new result and args.

gcc/testsuite/ChangeLog:

* gcc.dg/torture/pr121236-1.c: New test.
* gcc.dg/torture/pr121295-1.c: New test.

Signed-off-by: Andrew Pinski <quic_apinski@quicinc.com>
gcc/testsuite/gcc.dg/torture/pr121236-1.c [new file with mode: 0644]
gcc/testsuite/gcc.dg/torture/pr121295-1.c [new file with mode: 0644]
gcc/tree-if-conv.cc