From f8cbcb7c8ac944c54c57023fe7951ac1770941c2 Mon Sep 17 00:00:00 2001 From: Alexander Marx Date: Mon, 4 Nov 2013 08:04:44 +0100 Subject: [PATCH] Firewall: Bugfix: When creating a servcie in firewall-groups and selecting a protocol other than icmp, the enty in the ruletable shows correct values PLUS the "all icmp-types" under ICMP. Now the ICMP FIeld is emtpy when selecting another protocol than icmp --- html/cgi-bin/fwhosts.cgi | 1 + 1 file changed, 1 insertion(+) diff --git a/html/cgi-bin/fwhosts.cgi b/html/cgi-bin/fwhosts.cgi index fd66a49414..91de897ec9 100755 --- a/html/cgi-bin/fwhosts.cgi +++ b/html/cgi-bin/fwhosts.cgi @@ -741,6 +741,7 @@ if ($fwhostsettings{'ACTION'} eq 'saveservice') } } if($ICMP eq ''){$ICMP=$fwhostsettings{'ICMP_TYPES'};} + if ($fwhostsettings{'PROT'} ne 'ICMP'){$ICMP='';} if (!$errormessage){ my $key = &General::findhasharraykey (\%customservice); foreach my $i (0 .. 4) { $customservice{$key}[$i] = "";} -- 2.39.2