From 80fb188790d3b75bc58f8feb83d6ed8ceda5c17e Mon Sep 17 00:00:00 2001 From: Roman Bogorodskiy Date: Sat, 11 Apr 2026 15:28:55 +0200 Subject: [PATCH] qemu: fix success return from qemuDomainGetHostnameLease The current qemuDomainGetHostnameLease() implementation jumps to the "endjob" label when it finds hostname. As the label is defined after "ret = 0", qemuDomainGetHostnameLease() returns -1 in this case. That works because in qemuDomainGetHostname() it is used like that: ... if (qemuDomainGetHostnameLease(vm, &hostname) < 0) goto cleanup; ... cleanup: virDomainObjEndAPI(&vm); return hostname; } So it works, but it looks confusing. To make more consistent, use 'break' in qemuDomainGetHostnameLease() when the hostname is found, so it returns 0 in this case. Fixes: a4a5827c9fc396f2b1848c1d393385535b106d1a Signed-off-by: Roman Bogorodskiy Reviewed-by: Peter Krempa --- src/qemu/qemu_driver.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c index 2d31d4aa31..a3bcfc701d 100644 --- a/src/qemu/qemu_driver.c +++ b/src/qemu/qemu_driver.c @@ -16434,6 +16434,8 @@ qemuDomainGetHostnameLease(virDomainObj *vm, size_t i, j; int ret = -1; + *hostname = NULL; + if (virDomainObjBeginJob(vm, VIR_JOB_QUERY) < 0) return -1; @@ -16471,7 +16473,7 @@ qemuDomainGetHostnameLease(virDomainObj *vm, VIR_FREE(leases); if (*hostname) - goto endjob; + break; } ret = 0; -- 2.47.3